[FFmpeg-devel] [PATCH] libavcodec/mmaldec.c: add interlaced_frame and format struct to AVFrame for deinterlacing

[Jens Ziller]

Am Sonntag, den 03.07.2016, 19:36 +0200 schrieb Jens Ziller:
> Am Sonntag, den 03.07.2016, 18:05 +0200 schrieb Moritz Barsnick:
> > 
> > On Sun, Jul 03, 2016 at 17:20:41 +0200, Jens Ziller wrote:
> > > 
> > > 
> > > Am Samstag, den 02.07.2016, 17:54 +0200 schrieb Moritz Barsnick:
> > > > 
> > > > 
> > > > On Sun, Jun 26, 2016 at 17:12:14 +0200, Jens Ziller wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > +        ctx->interlaced_frame = !(interlace_type.eMode ==
> > > > > MMAL_InterlaceProgressive);
> > > > What's wrong with using the "!=" operator instead?
> > > "!=" is a comparing. "= !()" assign with a negate. Here is "=
> > > !()"
> > > needed.
> > I meant the comparison, not the assignment, so replacing:
> >   ctx->interlaced_frame = !(interlace_type.eMode ==
> > MMAL_InterlaceProgressive)
> > with
> >   ctx->interlaced_frame = (interlace_type.eMode !=
> > MMAL_InterlaceProgressive)
> > 
> > The former is rather ... convoluted.
> > (Brackets optional, but probably better for readability.)
> > 
> > Moritz
> Oh, sorry! I'am so blind. Yes, that's not really smart. I changed
> that.
> The new patch is attached.
> 
> Regards Jens
> 

Hello Michael and list,

this patch was discussed and improved on the ML. What can I still do
that my app get interlaced_frame and a pointer to the existing
MMAL_ES_FORMAT_T from ffmpeg? mmaldec.c have unfortunately no
maintainer.

regards Jens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-v4-fill-AVFrame-interlaced_frame-with-MMAL_PARAMETER.patch
Type: text/x-patch
Size: 3113 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160716/c646233e/attachment.bin>