[FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: Restoring decoding functionality after unsuccessful merge from libav.

[Mark Thompson]

On 23/07/16 20:33, Ivan Uskov wrote:
> If  you are use qsv, I would like to recommend to roll-back to version before
> d30cf57a7b2097b565db02ecfffbdc9c16423d0e
> Really  the  d30cf57a7b2097b565db02ecfffbdc9c16423d0e is useless and only
> makes code complex and work slow, the sync variable is not mandatory to be
> allocated  on  heap  at  all.  libav  guys  did a big mistake when have added
> such "feature".

Are you sure that works correctly with all streams, maybe one with some sort of delay?  It looks like you can add multiple things to the fifo in one call and but then only ever remove one, so using the stack to hold them across invocations is not appropriate (though failure may be very subtle).

(Note that I'm not sufficiently familiar with Media SDK to confidently assert anything about how this code should behave, so please don't read too much into what I say.)

In general I think if you are happy that the previous implementation in ffmpeg was correct then please do revert, because the code as it is now is completely broken.

Thanks,

- Mark