[FFmpeg-devel] [PATCH 1/2] v2 SCTE extraction from mpegts

[Michael Niedermayer]

On Mon, Jul 25, 2016 at 12:25:16PM -0700, Carlos Fernandez Sanz wrote:
> From: Carlos <carlos at ccextractor.org>
> 
> Signed-off-by: carlos <carlos at ccextractor.org>
> ---
>  libavcodec/avcodec.h    |  1 +
>  libavcodec/codec_desc.c |  6 ++++++
>  libavformat/mpegts.c    | 46 ++++++++++++++++++++++++++++++++++++++++------
>  3 files changed, 47 insertions(+), 6 deletions(-)

This breaks http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket1827/vc1_dts_mplayerAudioProblem_sb41_cut.m2ts
which after the patch has a stream that seems dts detected as
SCTE_35 resultig in lack of audio
the sample is sadly a bit short

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160726/33c8322c/attachment.sig>