[FFmpeg-devel] [PATCH]Filter: Add snapshot filter. It is enable to save snapshot.

[Nicolas George]

Le quartidi 14 prairial, an CCXXIV, kl222 a écrit :
> I understand your usage scenario. But I am not specified snapshot file
> name on the command line. But it needs to be updated it is, another
> program specified file name. So, I think as a separate filter is better.

I think you will need to do a little better than that: you can not wave the
objections to your patch away, you need to explain why they are less
important than your wish of specifying the output file name on the command
stream.

IMHO, they are not: the calling code can as easily rename the output file to
its final name. I might add that having an output file name specified
through a command channel is at least a security concern: since it is a
rarely used feature, people will often forget it exists when auditing new
code.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160603/d2b8c077/attachment.sig>