[FFmpeg-devel] [PATCH] aacsbr: reduce element type mismatch warning severity

[Rostislav Pehlivanov]

On 4 June 2016 at 20:37, Rostislav Pehlivanov <atomnuker at gmail.com> wrote:

> All HE-AAC samples with an LFE channel make this warning get spammed on
> every frame. Turning off SBR for LFE channels makes sense (since it has
> much less coefficients than normal channels do), so this error print is
> of no value in this case.
> It makes sense to keep the error in other cases, hence why it's still
> around, degraded to warning severity since the decoder will still
> attempt to decode without SBR.
>
> Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
> ---
>  libavcodec/aacsbr_template.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/aacsbr_template.c b/libavcodec/aacsbr_template.c
> index 733e619..5110542 100644
> --- a/libavcodec/aacsbr_template.c
> +++ b/libavcodec/aacsbr_template.c
> @@ -1473,7 +1473,7 @@ void AAC_RENAME(ff_sbr_apply)(AACContext *ac,
> SpectralBandReplication *sbr, int
>      int err;
>
>      if (id_aac != sbr->id_aac) {
> -        av_log(ac->avctx, AV_LOG_ERROR,
> +        av_log(ac->avctx, id_aac == TYPE_LFE ? AV_LOG_VERBOSE :
> AV_LOG_WARNING,
>              "element type mismatch %d != %d\n", id_aac, sbr->id_aac);
>          sbr_turnoff(sbr);
>      }
> --
> 2.8.1.369.geae769a
>
>
Pushed
More and more users were getting fooled into thinking they have invalid
files.