[FFmpeg-devel] [PATCH] swscale/swscale-test: Code to test scaler with slices

[Michael Niedermayer]

On Wed, Jun 08, 2016 at 10:04:46PM -0300, Pedro Arthur wrote:
> Hi, I took the time to investigate it and I find a few bugs which I'm
> attaching a patch for them.

patches LGTM


> Yet I'm not convinced that it is a definitive fix, since the output of
> swscale-test differs in some cases when scaling the whole frame or in
> slices.

swscale-test tests alot, really alot
some of the things it test are possibly buggy independant of slices
i didnt check what remains though


> Also there is a few fixes needed in this patch which took me a while to
> figure out because I blindly trusted the patch was correct.

never trust code, especially not a patch just posted that could not
have been fully tested

also thanks alot for looking into this!


> 
> 2016-06-05 9:27 GMT-03:00 Michael Niedermayer <michael at niedermayer.cc>:
> 
> > +        src_tmp[0] += srcStride[0] * i * STEP;
> >
> here it should be:
> src_tmp[0] += srcStride[0] * i;
> 
> +        if (src_tmp[2]) {
> > +            int step = STEP >> desc_src->log2_chroma_h;
> >
> +            src_tmp[1] += srcStride[1] * i * step;
> > +            src_tmp[2] += srcStride[2] * i * step;
> > +        }
> > +        if (src_tmp[3])
> > +            src_tmp[3] += srcStride[3] * i * STEP;
> >
> The same applies for the above code.
> 
> Regards,
> Pedro.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160609/bfadf7a0/attachment.sig>