[FFmpeg-devel] [RFC] BSF list API

[Nicolas George]

Le quartidi 24 prairial, an CCXXIV, Marton Balint a écrit :
> Maybe I am missing something, but as far as I see the alloc is due to the
> alloc in ff_bsf_get_packet. We could create a similar function
> ff_bsf_get_packet2(AVBSFContext *ctx, AVPacket *pkt) which does not allocate
> a packet but simply moves the ref to pkt. Then this can be called with the
> output packet pointer, so no allocation will be requried. And this function
> can be used for performance sensitive places instead of the original.

Indeed, maybe it is as simple as that.

> I think we need to support both ways to configure the bsf list. What the tee
> muxer, or ffmpeg.c would use, is the text based configuration, therefore
> it's worth adding the capability of parsing such lists.

That is exactly what I was suggesting.

> So what we need, on top of what I proposed, is an additional API what you
> proposed (av_bsf_list_append), and which can be used to add filters to the
> list, after we allocated the list filter, but before we initialized it.

No, definitely no. It must be the other way around. Building a text API on
top of a programmatic is fairly common, building a programmatic API on top
of a text API is bad design.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160612/d4d1583f/attachment.sig>