[FFmpeg-devel] [PATCH] swresample: add exact_rational option

[Michael Niedermayer]

On Mon, Jun 13, 2016 at 07:46:22AM +0700, Muhammad Faiz wrote:
> On Mon, Jun 13, 2016 at 2:19 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Sun, Jun 12, 2016 at 07:56:31AM +0700, Muhammad Faiz wrote:
> >> give high quality resampling
> >> as good as with linear_interp=on
> >> as fast as without linear_interp=on
> >> tested visually with ffplay
> >> ffplay -f lavfi "aevalsrc='sin(10000*t*t)', aresample=osr=48000,
> >> showcqt=gamma=5"
> >> ffplay -f lavfi "aevalsrc='sin(10000*t*t)',
> >> aresample=osr=48000:linear_interp=on, showcqt=gamma=5"
> >> ffplay -f lavfi "aevalsrc='sin(10000*t*t)',
> >> aresample=osr=48000:exact_rational=on, showcqt=gamma=5"
> >>
> >> slightly speed improvement
> >> for fair comparison with -cpuflags 0
> >> audio.wav is ~ 1 hour 44100 stereo 16bit wav file
> >> ffmpeg -i audio.wav -af aresample=osr=48000 -f null -
> >>         old         new
> >> real    13.498s     13.121s
> >> user    13.364s     12.987s
> >> sys      0.131s      0.129s
> >>
> >> linear_interp=on
> >>         old         new
> >> real    23.035s     23.050s
> >> user    22.907s     22.917s
> >> sys      0.119s     0.125s
> >>
> >> exact_rational=on
> >> real    12.418s
> >> user    12.298s
> >> sys      0.114s
> >>
> >> possibility to decrease memory usage if soft compensation is ignored
> >
> > interresting
> >
> > can you add some fate tests ?
> > (that way this also could be easily tested for platform specific bugs)
> >
> patch attached
> 
> thanks

>  libswresample.mak |  256 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 256 insertions(+)
> 4eb9fee1d5502d816f8ea988d893b19bde8ac7c5  0001-fate-add-libswresample-exact_rational-test.patch
> From bddd8cff10cff568dcec8cb953168b6aedc2d5a2 Mon Sep 17 00:00:00 2001
> From: Muhammad Faiz <mfcc64 at gmail.com>
> Date: Mon, 13 Jun 2016 07:35:40 +0700
> Subject: [PATCH] fate: add libswresample exact_rational test

tested on linux32/64 mingw32/64 mips and arm
works fine

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160613/f361660d/attachment.sig>