[FFmpeg-devel] [PATCH] lavf/mov: ignore ctts entries that do not apply to a least one sample

[Matthieu Bouron]

On Fri, Jun 17, 2016 at 01:26:10AM +0200, Michael Niedermayer wrote:
> On Thu, Jun 16, 2016 at 05:26:14PM +0200, Matthieu Bouron wrote:
> > From: Matthieu Bouron <matthieu.bouron at stupeflix.com>
> > 
> > Fixes packet pts of samples which contain ctts entries with count=0.
> > ---
> > 
> > Hello,
> > 
> > The following patch fixes packet pts of samples which contain ctts values with
> > count=0 (so the ctts entry does not apply to any sample if I understand
> > correctly). Such samples are produced by a LG G4 phone. I don't have any
> > sample I can share at the moment (and thus no fate test following this patch
> > yet).
> > 
> > An alternative to this patch is to remove directly the entry when the ctts atom
> > is parsed. Would you prefer this alternative ?
> 
> i dont know what is preferred but i agree about either solution
> 
> removing them on load would avoid any issues with ctts_count > 0
> and no real entries, i dont know though if that ever matters

I've attached the alternative patch that removes the CTTS entries with
count <= 0 at parsing time. I think it's better in the end (I first liked
the idea to keep the ctts table as is in memory but after some thoughts I
think it's really useful). Anyway I'll go with whatever patch you prefer.

Matthieu

[...]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-mov-ignore-ctts-that-do-not-apply-to-a-least-on.patch
Type: text/x-diff
Size: 1798 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160620/748a05e5/attachment.patch>