[FFmpeg-devel] [PATCH] avfilter/vf_rotate: add >8 bit depth support

Hendrik Leppkes h.leppkes at gmail.com
Sun Jun 26 09:44:19 CEST 2016

On Sun, Jun 26, 2016 at 9:30 AM, Paul B Mahol <onemda at gmail.com> wrote:
> On 6/26/16, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Muhammad Faiz <mfcc64 <at> gmail.com> writes:
>>> I think it's not because of bit-exact problem.
>>> But because fate probes supported formats (with
>>> libavfilter/tests/filtfmts)
>>> On BE machine, code with native formats will generate error
>>> because fate-ref contains yuv*le entries but fate expects yuv*be
>> We control the fate test, so we can require an additional
>> (bit-exact) conversion from BE to LE to make the fate
>> test pass.
> Really, even for pixfmts?
> I will apply this as is. Feel free to add your hacks if you want, after.

You force a conversion before your filter now for everyone on BE, the
alternative is to make fate force a conversion after your filter and
only for fate (same conversion, just at a different point in the
filter graph)
Most high-bitdepth tests already do this, simply by requesting a
defined pixfmt in the fate test.

Clearly less forced conversions is better?

- Hendrik

More information about the ffmpeg-devel mailing list