[FFmpeg-devel] [PATCH] configure: use c++98 for c++ files

[Richard Kern]

> On Jun 26, 2016, at 6:20 PM, Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> On Sun, Jun 26, 2016 at 06:00:41PM -0400, Richard Kern wrote:
>> 
>>> On Jun 26, 2016, at 5:55 PM, Michael Niedermayer <michael at niedermayer.cc> wrote:
>>> 
>>> On Sun, Jun 26, 2016 at 05:44:11PM -0400, Richard Kern wrote:
>>>> 
>>>>> On Jun 26, 2016, at 5:26 PM, Michael Niedermayer <michael at niedermayer.cc> wrote:
>>>>> 
>>>>> On Sun, Jun 26, 2016 at 05:22:01PM -0400, Richard Kern wrote:
>>>>>> 
>>>>>>> On Jun 26, 2016, at 5:10 PM, Michael Niedermayer <michael at niedermayer.cc> wrote:
>>>>>>> 
>>>>>>> On Sun, Jun 26, 2016 at 04:44:40PM -0400, Rick Kern wrote:
>>>>>>>> Use c++98 standard instead of c++11.
>>>>>>>> 
>>>>>>>> Signed-off-by: Rick Kern <kernrj at gmail.com>
>>>>>>>> ---
>>>>>>>> configure | 2 +-
>>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>> 
>>>>>>>> diff --git a/configure b/configure
>>>>>>>> index 19aea61..76d2d27 100755
>>>>>>>> --- a/configure
>>>>>>>> +++ b/configure
>>>>>>>> @@ -4529,7 +4529,7 @@ fi
>>>>>>>> 
>>>>>>>> add_cppflags -D_ISOC99_SOURCE
>>>>>>>> add_cxxflags -D__STDC_CONSTANT_MACROS
>>>>>>>> -add_cxxflags -std=c++11
>>>>>>>> +add_cxxflags -std=c++98
>>>>>>> 
>>>>>>> should this not be check_cxxflags ?
>>>>>> 
>>>>>> Some c++ standard needs to be there to override the -std=c99 that gets pulled in from CFLAGS.
>>>>> 
>>>>> but does every compiler support -stc=... ?
>>>>> if one doesnt the c99 case would not have been added
>>>> 
>>>> What about filtering the -std=c99 out of CFLAGS in the CXXFLAGS assignment?
>>> 
>>> have you confirmed that -std=c99 is the problem ?
>> 
>> Yes, it dies at:
>> error: invalid argument '-std=c99' not allowed with 'C++/ObjC++'
>> make: *** [libavdevice/decklink_common.o] Error 1
> 
> why does this happen now and not before ?

It’s a warning on other compilers, but it’s been an issue on OS X for a while (was reported in late 2014).

> and what compiler is that ?

clang

> does it work when its filtered out ?

yes - I’ll submit a patch shortly.

> if so i guess, please do that
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Avoid a single point of failure, be that a person or equipment.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel