[FFmpeg-devel] [PATCH] h264: make H264ParamSets sps const

Benoit Fouet benoit.fouet at free.fr
Mon Jun 27 12:02:11 CEST 2016


On 25/06/2016 14:15, Clément Bœsch wrote:
> On Fri, Jun 24, 2016 at 09:20:35AM +0200, Benoit Fouet wrote:
> [...]
>>>> Any objection to this patch now?
>>> iam ok with the patch, maybe give others a bit of time to reply
>>> before applying though
>> Yeah, I'm in no hurry, I just saw this FIXME in the context of one of
>> Mateo's patches.
>> I was more waiting for some feedback from Hendrik or Clément, anyway, as
>> they were the ones raising the points.
> Should be fine if indeed the following computation:
>          int width  = 16 * sps->mb_width;
>          int height = 16 * sps->mb_height * (2 - sps->frame_mbs_only_flag);
> ...is always correct.

Good one. It seems the check that is done today on the height part is 
not enough.
I've also found another place which was writing to the SPS and shouldn't.
I'm sending a new patchset for all this.

Thanks for the review,

More information about the ffmpeg-devel mailing list