[FFmpeg-devel] [PATCH v3] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes

[Richard Kern]

> On Jun 26, 2016, at 11:03 PM, Roger Pack <rogerdpack2 at gmail.com> wrote:
> 
> could you post a copy of the compile failure for reference?

See below - the error is only generated when -I is used.

g++ -I. -Isrc/ -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/Users/rick/projects/ffmpeg/compat/dispatch_semaphore -DPIC -DZLIB_CONST -I/usr/local/include -std=c99 -fomit-frame-pointer -fPIC -pthread -g -Wdeclaration-after-statement -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast -Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch -Wno-format-zero-length -Wno-pointer-sign -Wno-unused-const-variable -O3 -fno-math-errno -fno-signed-zeros -Qunused-arguments -Werror=implicit-function-declaration -Werror=missing-prototypes -Werror=return-type  -D__STDC_CONSTANT_MACROS -std=c++98  -c -o libavdevice/decklink_common.o src/libavdevice/decklink_common.cpp
In file included from src/libavdevice/decklink_common.cpp:26:
/usr/local/include/DeckLinkAPIDispatch.cpp:56:6: error: no previous prototype for function 'InitDeckLinkAPI' [-Werror,-Wmissing-prototypes]
void    InitDeckLinkAPI (void)
        ^
/usr/local/include/DeckLinkAPIDispatch.cpp:77:7: error: no previous prototype for function 'IsDeckLinkAPIPresent' [-Werror,-Wmissing-prototypes]
bool            IsDeckLinkAPIPresent (void)
                ^
/usr/local/include/DeckLinkAPIDispatch.cpp:157:6: error: no previous prototype for function 'InitBMDStreamingAPI' [-Werror,-Wmissing-prototypes]
void InitBMDStreamingAPI(void)
     ^
3 errors generated.
make: *** [libavdevice/decklink_common.o] Error 1

> 
> On 6/26/16, Rick Kern <kernrj at gmail.com> wrote:
>> decklink_common.cpp includes a .cpp file from the DeckLink API which fails
>> to build because there are non-static functions in the included .cpp file.
>> This disables the missing-prototypes error so the file can be included.
>> 
>> Signed-off-by: Rick Kern <kernrj at gmail.com>
>> ---
>> libavdevice/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/libavdevice/Makefile b/libavdevice/Makefile
>> index 585827b..e281825 100644
>> --- a/libavdevice/Makefile
>> +++ b/libavdevice/Makefile
>> @@ -19,6 +19,8 @@ OBJS-$(CONFIG_BKTR_INDEV)                += bktr.o
>> OBJS-$(CONFIG_CACA_OUTDEV)               += caca.o
>> OBJS-$(CONFIG_DECKLINK_OUTDEV)           += decklink_enc.o decklink_enc_c.o
>> decklink_common.o
>> OBJS-$(CONFIG_DECKLINK_INDEV)            += decklink_dec.o decklink_dec_c.o
>> decklink_common.o
>> +$(SUBDIR)decklink_common.o: CXXFLAGS += -Wno-error=missing-prototypes
>> +
>> OBJS-$(CONFIG_DSHOW_INDEV)               += dshow_crossbar.o dshow.o
>> dshow_enummediatypes.o \
>>                                             dshow_enumpins.o dshow_filter.o
>> \
>>                                             dshow_pin.o dshow_common.o
>> --
>> 2.9.0
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel