[FFmpeg-devel] [PATCH] avutil/frame: Move new field to the end of AVFrame

Michael Niedermayer michael at niedermayer.cc
Thu Jun 30 02:13:03 CEST 2016


On Thu, Jun 30, 2016 at 01:25:59AM +0200, Hendrik Leppkes wrote:
> On Thu, Jun 30, 2016 at 12:50 AM, Timo Rothenpieler
> <timo at rothenpieler.org> wrote:
> >>> While it's true that all fields after it are not public API/ABI, a lot
> >>> of software seems to misuse it, so to avoid too much trouble for now,
> >>> this should be fixed.
> >>
> >> How do you expect library users to start using the API correctly if every
> >> time they do something wrong we are the ones that rush to break our code
> >> just to adapt to their mistakes?
> >
> > During an actual major bump, where such breakage is expected.
> > A lot of stuff gets it wrong, and it is indeed confusing, so putting all
> > blame on API users seems wrong to me. Specially as this issue will block
> > distributions from adapting 3.1.
> 
> Plenty previous releases moved fields that were marked as "no direct
> access", usually because libav added a new field above the
> ffmpeg-exclusive ones (like AVFrame.channels, which is a common
> candidate), and we didn't do such a song and dance to accomodate
> everyone.

> I asked this in other threads before - why this time?

because it caused bugs this time which we could fix, previously either
we couldnt fix them without breaking something else or noone was
affected/reported anything or we did fix them

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship: All citizens are under surveillance, all their steps and
actions recorded, for the politicians to enforce control.
Democracy: All politicians are under surveillance, all their steps and
actions recorded, for the citizens to enforce control.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160630/43037dc1/attachment.sig>


More information about the ffmpeg-devel mailing list