[FFmpeg-devel] [PATCH] fate: add filter-hls

[Michael Niedermayer]

On Tue, Mar 01, 2016 at 12:17:33AM -0300, James Almer wrote:
> On 2/29/2016 11:47 PM, Michael Niedermayer wrote:
> > ---
> >  tests/fate/filter-audio.mak |    7 +
> >  tests/ref/fate/filter-hls2  |  768 +++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 775 insertions(+)
> >  create mode 100644 tests/ref/fate/filter-hls1
> >  create mode 100644 tests/ref/fate/filter-hls2
> > 
> > diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
> > index 85a36d2..a330a93 100644
> > --- a/tests/fate/filter-audio.mak
> > +++ b/tests/fate/filter-audio.mak
> > @@ -3,6 +3,13 @@ fate-filter-adelay: tests/data/asynth-44100-2.wav
> >  fate-filter-adelay: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav
> >  fate-filter-adelay: CMD = framecrc -i $(SRC) -af adelay=42
> >  
> > +FATE_AFILTER-$(call ALLYES, HLS_DEMUXER MOV_MUXER MOV_DEMUXER AEVALSRC_FILTER LAVFI_INDEV MP2FIXED_ENCODER) += fate-filter-hls1 fate-filter-hls2
> 
> Shouldn't it be MPEGTS instead of MOV?

fixed


> 
> > +tests/data/hls-list.m3u8: fate-filter-hls1
> > +fate-filter-hls1: CMD = run ffmpeg -f lavfi -i "aevalsrc=cos(2*PI*t)*sin(2*PI*(440+4*t)*t)::d=20" -f segment -segment_time 10 -map 0 -flags +bitexact -codec:a mp2fixed \
> > +                                   -segment_list $(TARGET_PATH)/tests/data/hls-list.m3u8 $(TARGET_PATH)/tests/data/hls-out-%03d.ts
> 
> Add a "fate-filter-hls1: REF = /dev/null" line here to avoid the empty ref file.

fixed


> 
> > +fate-filter-hls2: tests/data/hls-list.m3u8
> 
> Why not just add fate-filter-hls1 as dep here, and get rid of the m3u8 target above?

i think that isnt correct
consider that the m3u8 has been build previously and the user runs
make fate-filter-hls2
the hls1 test should not run in that case, its not needed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160301/3e38ad50/attachment.sig>