[FFmpeg-devel] [PATCH v9] VideoToolbox H.264 Encoder

[Richard Kern]

> On Mar 2, 2016, at 12:11 AM, wm4 <nfxjfg at googlemail.com> wrote:
> 
> On Tue, 01 Mar 2016 14:57:29 +0000
> Timothy Gu <timothygu99 at gmail.com <mailto:timothygu99 at gmail.com>> wrote:
> 
>> Hi,
>> 
>> On Mon, Feb 29, 2016 at 9:42 PM Rick Kern <kernrj at gmail.com> wrote:
>> 
>>> Autodetected by default. Encode using -codec:v vtenc.
>>> 
>>> Signed-off-by: Rick Kern <kernrj at gmail.com>
>>> ---
>>> MAINTAINERS            |    1 +
>>> configure              |   19 +
>>> libavcodec/Makefile    |    1 +
>>> libavcodec/allcodecs.c |    1 +
>>> libavcodec/vtenc.c     | 1339
>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>> 5 files changed, 1361 insertions(+)
>>> create mode 100644 libavcodec/vtenc.c
>>> 
>> 
>> We already have videotoolbox AVHWAccel. Maybe it would be better to change
>> the name of the file to videotoolboxenc.c so that it's easier to associate
>> these two files?
> 
> I don't mind. They're pretty different after all.
Sounds good. I’ll rename it.

> 
>> 
>>> +AVCodec ff_vtenc_encoder = {  
>> 
>>> +    .name             = "vtenc",
>>> +    .long_name        = NULL_IF_CONFIG_SMALL("VideoToolbox H.264
>>> Encoder"),
>>> 
>> 
>> The norm seems to be using "h264_videotoolbox" (like "h264_qsv") so that
>> potential future extensions to VideoToolbox can be supported without
>> changing the name of the codec.
>> 
> 
> Good point.
Ok. I’d also like to make configure —enable-videotoolbox apply to the VideoToolbox external library, not just the hwaccel. The VideoToolbox hwaccel build code will have to be updated to depend on the external library, but then disabling VideoToolbox-related code requires one parameter. The names of the hwaccels would stay the same, so I don’t see any backwards compatibility issues.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org <mailto:ffmpeg-devel at ffmpeg.org>
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>