[FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

Thilo Borgmann thilo.borgmann at mail.de
Fri Mar 4 11:25:24 CET 2016


You are skipping everything I think about N-tags you want to patch away... why?

Am 04.03.16 um 11:07 schrieb Timo Rothenpieler:
>> So what about the release tag? Well it is a quite useful extension because of
>> the already mentioned possibility of determining the existing features at once.
>> I'm pro adding it to the version string.
> 
> The release tags are not made in the master branch, so git describe
> won't pick them up.
> They also don't have a meaning for master, as there are distinct commits
> between the two.

The reason for the version tag is the user, not? The user does not care about
git describe, teh user wants teh release number in his version string.
If I read you correctly you are arguing in some way against your own change?
(not haveing the release tag?)


>> The tag-tag? (devxy) I don't see it anywhere except in git and therefore it is
>> uselessly redundant to the existing hash tag in my eyes. Why add another more
>> roughly estimation of the users repo-state? I don't think this should be added
>> to the version string.
> 
> A new dev tag is made every time a release is branched off, to indicate
> development of the next ffmpeg version started there, so using it for
> the version number seems natural to me.

I still see no benefit in adding it. If there is the release tag, I don't need
this because they are redundant. If there is no release tag, the user would
manually find the release number for this tag, not?

-Thilo



More information about the ffmpeg-devel mailing list