[FFmpeg-devel] [PATCH] avcodec: try to document timebase and framerate a bit more

[Michael Niedermayer]

On Sat, Mar 05, 2016 at 06:01:11PM +0100, Reimar Döffinger wrote:
> On Sat, Mar 05, 2016 at 01:41:32PM +0100, Michael Niedermayer wrote:
> > +     * Note, for variable framerate material this has undefined meaning currently
> > +     * and is not set to the actual framerate nor {0,1} but can be set to
> > +     * 1/timebase (FIXME) the code in some parts assumes framerate == 1/timebase
> > +     * which is generally not true but these parts need to be fixed before framerate
> > +     * can be fixed.
> 
> This is too complex, maybe it can be split in multiple sentences.
> Suggestion (but I took a lot of liberty and it might not say what you
> meant!):
> 
> Note: meaning is not yet defined for variable frame rate content.
> Ideally it should be set to either the current frame rate or {0,1}
> for that case.
> However for this some code assuming framerate == 1/timebase needs to
> be fixed first - until then this field may incorrectly be set
> to 1/timebase.

there are 2 cases
1. encoding where the users sets it
2. deoding where lavc sets it

my comment was about decoding "issues"/"bugs"
i think user apps should always set it correctly when encoding
"git grep framerate libavcodec/*enc*c" looks like its basically unused
for encoders.

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160305/10d192b7/attachment.sig>