[FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

[Mats Peterson]

On 03/05/2016 06:14 PM, Michael Niedermayer wrote:
> On Sat, Mar 05, 2016 at 05:54:05PM +0100, Reimar Döffinger wrote:
>> On Sat, Mar 05, 2016 at 02:32:56PM +0100, Mats Peterson wrote:
>>> On 03/05/2016 02:24 PM, Mats Peterson wrote:
>>>>
>>>> The original toon.avi doesn't contain xxpc chunks at keyframes either,
>>>> if that can be of any comfort. It only contains two xxpc chunks, at
>>>> that. If you're able to invent something nice regarding palette changes
>>>> on keyframes, please go ahead. But please add what's available in the
>>>> meantime.
>>>>
>>>> Mats
>>>>
>>>
>>> In my book it should be up to the demuxer/decoder to keep track of previous
>>> palettes. You said yourself that no xxpc chunks should be included if they
>>> are identical to the first palette.
>>
>> Define "previous".
>> What you suggests means that for a 1 GB video, if you want to see the
>> only the last frame the demuxer would _always_ have to parse the whole 1GB
>> just to make sure it has the last palette.
>> Thus the desire to always have a complete palette included for
>> "keyframes", which exist exactly so you can start playing
>> without parsing the whole file first.
>> Obviously patches don't have to solve every problem from the start,
>> but then again half the time to revise them faster than anyone can check
>> them...
>
>> Btw. sorry, maybe Michael manages, but I at least won't be able to
>> even read, much less properly follow all your emails if you
>> write that many.
>
> same problem here
> ive applied the latest now, as i think its less work to build on top
> of that and fix what remains ...
>
>

That's my idea. Thanks, Michael.

Mats