[FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Mar 6 13:34:55 CET 2016


On Sun, Mar 06, 2016 at 01:15:33PM +0100, Mats Peterson wrote:
> On 03/06/2016 12:55 PM, Mats Peterson wrote:
> >On 03/06/2016 12:51 PM, Mats Peterson wrote:
> >>On 03/06/2016 12:09 PM, Michael Niedermayer wrote:
> >>
> >>Once again, why are these tests unneeded?
> >>
> >>Mats
> >>
> >
> >avio_tell() won't work on an unseekable stream, since it uses
> >avio_seek(), as far as I know.
> 
> In that respect (that it won't work on an unseekable stream), it's similar
> to ftell().

First, it doesn't fail as there is no reason for it to fail.
Unseekable doesn't mean a avio_seek will fail on principle,
that would be pointlessly constraint, it just means it can
and in certain cases is likely to fail.
As the result isn't used it doesn't matter whether it fails
anyway though, as long as it is guaranteed to not corrupt stream
state, which it is.


More information about the ffmpeg-devel mailing list