[FFmpeg-devel] [PATCH 1/2] lavf/avienc: Palette changing code only concerns AV_PIX_FMT_PAL8

[Mats Peterson]

On 03/08/2016 12:51 PM, Michael Niedermayer wrote:
> On Tue, Mar 08, 2016 at 11:42:48AM +0100, Mats Peterson wrote:
>> Forget the old one. Refactored some variables to more appropriate
>> locations as well.
>>
>> Mats
>>
>> --
>> Mats Peterson
>> http://matsp888.no-ip.org/~mats/
>
>>   avienc.c |   15 +++++----------
>>   1 file changed, 5 insertions(+), 10 deletions(-)
>> 6636f641c269c2365e65007213c143a3426e325c  0001-lavf-avienc-Palette-changing-code-only-concerns-AV_P.patch
>>  From 766dc9c46ed9d528d41505f8b67e18ef261f8f0e Mon Sep 17 00:00:00 2001
>> From: Mats Peterson <matsp888 at yahoo.com>
>> Date: Tue, 8 Mar 2016 11:26:32 +0100
>
>> Subject: [PATCH 1/2] lavf/avienc: Palette changing code only concerns AV_PIX_FMT_PAL8
>
> are pcXX chunks forbidden for other cases ?
> i mean 4bits per sample and such ?
> i dont see anything in the spec saying so, but it quite possibly
> might be
>
> [...]
>
>

No, they are allowed. But those bit depths will use AV_PIX_FMT_PAL8 in 
FFmpeg, since that's currently the only palettized mode. 
AV_PIX_FMT_MONOWHITE/MONOBLACK won't have a palette, so it's unnecessary 
to enter the block for these pixel formats.

Mats