[FFmpeg-devel] [PATCH] lavc/aacenc_quantization: use cbrt table

[Ganesh Ajjanagadde]

On Thu, Mar 10, 2016 at 3:12 AM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On 10.03.2016, at 00:49, Ganesh Ajjanagadde <gajjanag at gmail.com> wrote:
>
>> There is no reason for computing cbrtf at runtime; we have a table for
>> this.
>>
>> Cruft needed due to the build system, the people who still like using
>> hardcoded tables and need for single cbrt_tab across the code.
>
> Could you please explain what exactly the problem is?
> Why would you need cbrt_table.c for example? You can just conditionally include it from cbrt_data.c for example.
> Hardcoded tables are meant to only change when the initialization code is run, not where the resulting data is located, i.e. it should only ever replace a
> int table[size];
> by
> const int table[size] = { data };
> (though with the indirection of placing the second one in a header)

The data can't go into a header; else one gets multiple copies, see
above. Please not that I may still be missing something; this
hardcoded ifdefry and build system is something I am not that familiar
with.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel