[FFmpeg-devel] [PATCH 1/3] lavf/riffenc: Improve spec compliance

[Mats Peterson]

On 03/12/2016 01:14 PM, Michael Niedermayer wrote:
> On Sat, Mar 12, 2016 at 11:43:32AM +0100, Mats Peterson wrote:
>>>>>> why do you think they are written by libavformat ?
>>>>>>
>>>>>> i see:
>>>>>> "C:\PROGRAM FILES\ASUS\ASUS LIVE\ASUSLIVE.EXE -AVICAP32- ASUS Video
>>>>>> Capture Driver, Version:  3.8.2.2"
>>>>>>
>>>>>> in asv2_320x240_3.avi
>>>>>>
>>>>>>
>>
>> Regarding asv1/asv2, they do use 48 in biSize, but since there is no
>> official documentation for these codecs that explicitly mentions
>> that biSize should be 48 (which breaks the specs), it's plain wrong
>> to use anything else than 40.
>
> just because the creator of a format chooses to keep the specs
> secret doesnt mean you can freely choose the formats of headers.
>
> What is correct for it is what the official software stores and it
> stores 48 not 40, also 48 is the value i would have expected that they
> would use.
>
>

Well, then they're breaking the specs, just like HuffYUV.

Mats