[FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Mar 12 15:07:55 CET 2016


Moritz Barsnick <barsnick <at> gmx.net> writes:

> > +    case AV_PIX_FMT_GBRP:
> > +    case AV_PIX_FMT_GBRP10:
> > +    case AV_PIX_FMT_GBRP12:
> > +        ctx->params->vui.matrixCoeffs = AVCOL_SPC_RGB;
> > +        ctx->params->vui.bEnableVideoSignalTypePresentFlag  = 1;
> > +        ctx->params->vui.bEnableColorDescriptionPresentFlag = 1;
> >      case AV_PIX_FMT_YUV444P:
> >      case AV_PIX_FMT_YUV444P10:
> >      case AV_PIX_FMT_YUV444P12:
> 
> Fallthrough intended?

Definitely.

> Might be worth documenting then, because reading
> such switch/cases can become confusing.

I believe we don't usually add a comment here, 
several files distinguish in a similar way between 
gbrp and yuv444p.

Carl Eugen



More information about the ffmpeg-devel mailing list