[FFmpeg-devel] [PATCH 1/2] avutil/dict: do not realloc entries when deleting a non-existing item

Marton Balint cus at passwd.hu
Sun Mar 13 03:03:30 CET 2016


Deleting a non-existing item should not invalidate existing entries returned
with av_dict_get.

Signed-off-by: Marton Balint <cus at passwd.hu>
---
 libavutil/dict.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavutil/dict.c b/libavutil/dict.c
index 8bb65a1..1203562 100644
--- a/libavutil/dict.c
+++ b/libavutil/dict.c
@@ -98,7 +98,7 @@ int av_dict_set(AVDictionary **pm, const char *key, const char *value,
             av_free(tag->value);
         av_free(tag->key);
         *tag = m->elems[--m->count];
-    } else {
+    } else if (copy_value) {
         AVDictionaryEntry *tmp = av_realloc(m->elems,
                                             (m->count + 1) * sizeof(*m->elems));
         if (!tmp)
-- 
2.6.2



More information about the ffmpeg-devel mailing list