[FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

[wm4]

On Mon, 14 Mar 2016 11:23:16 +0100
Clément Bœsch <u at pkh.me> wrote:

> On Mon, Mar 14, 2016 at 10:19:59AM +0100, Thilo Borgmann wrote:
> > Am 13.03.16 um 22:01 schrieb Clément Bœsch:  
> > > On Sun, Mar 13, 2016 at 09:09:39PM +0100, Thilo Borgmann wrote:  
> > >> Am 13.03.16 um 20:55 schrieb Nicolas George:  
> > >>> Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit :  
> > >>>> +    { "list_filters", "list available filters",  OFFSET(list_filters), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, .flags = FLAGS, "list_filters" },
> > >>>> +    { "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0, FLAGS, "list_filters" },
> > >>>> +    { "false", "", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0, FLAGS, "list_filters" },  
> > >>>
> > >>> You forgot to remove the constants.  
> > >>
> > >> Removed. Patch attached.
> > >>
> > >> -Thilo
> > >>  
> > >   
> > >> From 4aef8c0d09e109cedd92e17cc04a6ef6236c07ab Mon Sep 17 00:00:00 2001
> > >> From: Thilo Borgmann <thilo.borgmann at mail.de>
> > >> Date: Sun, 13 Mar 2016 21:08:18 +0100
> > >> Subject: [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering
> > >>  on OSX.
> > >>
> > >> ---
> > >>  Changelog                  |   1 +
> > >>  MAINTAINERS                |   1 +
> > >>  configure                  |   2 +
> > >>  doc/filters.texi           |  67 ++++++
> > >>  libavfilter/Makefile       |   1 +
> > >>  libavfilter/allfilters.c   |   1 +  
> > >   
> > >>  libavfilter/vf_coreimage.m | 551 +++++++++++++++++++++++++++++++++++++++++++++  
> > > 
> > > Sorry to raise that now, but isn't this API available in C as well (just
> > > like VT)?  
> > 
> > IIRC I've read somewhere that it is possible to access all the Objective-C API
> > directly via C... however, I find it in Apple's docs only for Core Audio so far
> > (which says something about C++).
> > 
> > Reference in C seems not to be there, and I assume Apple does not tell much
> > about using C neither cares much about such users. Also maintainability should
> > suffer from using C, you won't find much about using it and possible pitfalls in
> > the internet. On the contrary, I think Apple would much more like to see using
> > swift which would make it even further away from C... as long as we can stick to
> > Objective-C most of us should be familiar enough with it and I think it should
> > therefore be our choice.
> >   
> 
> Well, my concern is that we are a C project, and most people here
> (including me) can't really review not maintain this stuff properly.
> 

To be fair, at least Objective-C is 100% compatible to C99. It's not
like with C++.