[FFmpeg-devel] True HD encoder - Updated the mlpenc.c, MLP encoder

[Rostislav Pehlivanov]

On 17 March 2016 at 04:23, greeshma <greeshmabalabadra at gmail.com> wrote:

> Hello,
>
> The attached patch is MLP encoder added and updated for the task True HD
> encoder.
>
> Thank you,
>
> Greeshma B
>


Hi,

Doesn't compile:

libavcodec/mlpenc.c:569:12: warning: 'coded_frame' is deprecated
[-Wdeprecated-declarations]
    avctx->coded_frame = av_frame_alloc();
           ^
libavcodec/avcodec.h:2967:35: note: 'coded_frame' has been explicitly
marked deprecated here
    attribute_deprecated AVFrame *coded_frame;
                                  ^
libavcodec/mlpenc.c:684:5: error: implicit declaration of function
'ff_audiodsp_init' is invalid in C99
      [-Werror,-Wimplicit-function-declaration]
    ff_audiodsp_init(&ctx->dsp);
    ^
libavcodec/mlpenc.c:684:5: note: did you mean 'ff_mlpdsp_init'?
libavcodec/mlpdsp.h:79:6: note: 'ff_mlpdsp_init' declared here
void ff_mlpdsp_init(MLPDSPContext *c);
     ^
libavcodec/mlpenc.c:1462:35: warning: incompatible pointer types passing
'MLPDSPContext *' (aka 'struct MLPDSPContext *') to
      parameter of type 'LPCContext *' (aka 'struct LPCContext *')
[-Wincompatible-pointer-types]
        order = ff_lpc_calc_coefs(&ctx->dsp, ctx->lpc_sample_buffer,
ctx->number_of_samples,
                                  ^~~~~~~~~
libavcodec/lpc.h:93:35: note: passing argument to parameter 's' here
int ff_lpc_calc_coefs(LPCContext *s,
                                  ^
libavcodec/mlpenc.c:1572:62: warning: shifting a negative signed value is
undefined [-Wshift-negative-value]
            mp->coeff[0][0] =  1 << 14; mp->coeff[0][1] = -1 << 14;
                                                          ~~ ^
libavcodec/mlpenc.c:1574:62: warning: shifting a negative signed value is
undefined [-Wshift-negative-value]
            mp->forco[0][0] =  1 << 14; mp->forco[0][1] = -1 << 14;
                                                          ~~ ^
libavcodec/mlpenc.c:1582:62: warning: shifting a negative signed value is
undefined [-Wshift-negative-value]
            mp->forco[0][0] =  1 << 14; mp->forco[0][1] = -1 << 14;
                                                          ~~ ^
libavcodec/mlpenc.c:2319:12: warning: 'coded_frame' is deprecated
[-Wdeprecated-declarations]
    avctx->coded_frame->key_frame = restart_frame;
           ^
libavcodec/avcodec.h:2967:35: note: 'coded_frame' has been explicitly
marked deprecated here
    attribute_deprecated AVFrame *coded_frame;
                                  ^
libavcodec/mlpenc.c:2406:22: warning: 'coded_frame' is deprecated
[-Wdeprecated-declarations]
    av_freep(&avctx->coded_frame);
                     ^
libavcodec/avcodec.h:2967:35: note: 'coded_frame' has been explicitly
marked deprecated here
    attribute_deprecated AVFrame *coded_frame;
                                  ^
libavcodec/mlpenc.c:2419:26: warning: incompatible pointer types
initializing 'int (*)(AVCodecContext *, AVPacket *, const AVFrame
      *, int *)' (aka 'int (*)(struct AVCodecContext *, struct AVPacket *,
const struct AVFrame *, int *)') with an expression of
      type 'int (AVCodecContext *, uint8_t *, int, void *)' (aka 'int
(struct AVCodecContext *, unsigned char *, int, void *)')
      [-Wincompatible-pointer-types]
    .encode2           = mlp_encode_frame,