[FFmpeg-devel] [PATCH] lavc/aacenc_utils: unroll abs_pow34_v loop

[Rostislav Pehlivanov]

On 22 March 2016 at 18:14, Ganesh Ajjanagadde <gajjanag at gmail.com> wrote:
>
>
> Per doc/optimization.txt, aac is a widely used codec, so even a 0.1%
> improvement in aac is fair game for optimizations, assuming it is a
> small code change. Of course, one can debate whether this is small or
> not. I view it as simple and clean, others may disagree.


Nope, I still doubt that that 0.1% is a definite performance improvement.
Sure it might be on your machine but who knows, maybe for someone else
it'll be a 0.1% decrease in performance or hell, a 1% decrease. Maybe if
you ran the test when the Moon was overhead the extra decrease in gravity
could affect a nearby sea or lake and speed up water evaporation,
saturating the air with more moisture and therefore increasing its ability
to contain heat causing your CPU to throttle less since it's cooler.
Still far too small to justify this patch as a non-placebo improvement.