[FFmpeg-devel] [PATCH] lavc/aacenc_utils: unroll abs_pow34_v loop

[Hendrik Leppkes]

On Tue, Mar 22, 2016 at 7:37 PM, Ganesh Ajjanagadde <gajjanag at gmail.com> wrote:
> On Tue, Mar 22, 2016 at 11:30 AM, Rostislav Pehlivanov
> <atomnuker at gmail.com> wrote:
>> On 22 March 2016 at 18:14, Ganesh Ajjanagadde <gajjanag at gmail.com> wrote:
>>>
>>>
>>> Per doc/optimization.txt, aac is a widely used codec, so even a 0.1%
>>> improvement in aac is fair game for optimizations, assuming it is a
>>> small code change. Of course, one can debate whether this is small or
>>> not. I view it as simple and clean, others may disagree.
>>
>>
>> Nope, I still doubt that that 0.1% is a definite performance improvement.
>
> Then change doc/optimization.txt.

This particular doc doesn't give you a blanket argument. Specifically
if the maintainer objects on account of complexity, you should honor
that - the doc even says as much (ie. only "clean and simple" being
justified)

- Hendrik