[FFmpeg-devel] [PATCH 4/4] avformat/mov: add support for reading end padding from gapless itunes metadata

[Marton Balint]

On Tue, 22 Mar 2016, Michael Niedermayer wrote:

> On Mon, Mar 21, 2016 at 01:06:21AM +0100, Marton Balint wrote:
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  libavformat/mov.c                            | 13 ++++++++++---
>>  tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 12 ++++++------
>>  tests/ref/fate/gaplessinfo-itunes1           |  2 +-
>>  tests/ref/fate/gaplessinfo-itunes2           |  2 +-
>>  4 files changed, 18 insertions(+), 11 deletions(-)
>
> breaks (latest) fate
>
> some tests seem improve some seem to get worse

Hmm, it seems our HE-AAC decoder is using more samples for 
priming than it supposed to... Also there is the issue of duplicated 
sample rate in case of spectral band replication, which sooner or later 
will cause problems, because the priming is in the base sample rate but 
the codec sample rate is the duplicated sample rate...

I will extract the usable parts from this patchset, and re-send them, 
unfortunately I will not be able to work on gapless support further 
because of my limited knowledge of the AAC decoder, and that needs fixing 
as well, in order to not make things worse.

Regards,
Marton