[FFmpeg-devel] [PATCH] lavc/ccaption_dec: remove usage of avctx->time_base

[Clément Bœsch]

On Mon, Mar 28, 2016 at 04:57:51PM +0200, Michael Niedermayer wrote:
> On Mon, Mar 28, 2016 at 02:10:51PM +0200, Clément Bœsch wrote:
> > lavc/utils already rescales avpkt->pts to sub->pts in AV_TIME_BASE_Q
> > before calling the decode callback. This prevents from rescaling again
> > into the decoder, and avoid the use of avctx->time_base which will
> > disappear in the incoming codecpar merge.
> > 
> > This commit also replaces the use of "20 centisecond" (ass time base)
> > with "200 ms".
> > ---
> >  libavcodec/ccaption_dec.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> with
> ./ffmpeg -f lavfi -i "movie=Starship_Troopers.vob[out0+subcc]"  -vn -map s out.srt
> 
> this causes a moderate change in the timings
> is that intended ?
> 

Nope, that was a bug, thanks for noticing. It appears FATE isn't enough...

New patch attached.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavc-ccaption_dec-remove-usage-of-avctx-time_base.patch
Type: text/x-diff
Size: 3098 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160328/05a59f3a/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160328/05a59f3a/attachment.sig>