[FFmpeg-devel] [PATCH]Addition of MLP encoder

[Michael Niedermayer]

On Wed, Mar 30, 2016 at 06:38:33AM +0530, Disha Singh wrote:
> The most recent patch has been attached. The lpc error persists.
> I have removed some patcheck errors.
> 

[...]

> +/****************************************************************************
> + *************** Functions that process the data in some way ****************
> + ****************************************************************************/
> +
> +#define INT24_MAX ((1 << 23) - 1)
> +#define INT24_MIN (~INT24_MAX)
> +
> +#define MSB_MASK(bits)  (-1u << bits)
> +
> +/** Applies the filter to the current samples, and saves the residual back
> + *  into the samples buffer. If the filter is too bad and overflows the
> + *  maximum amount of bits allowed (24), the samples buffer is left as is and
> + *  the function returns -1.
> + */
> +static int apply_filter(MLPEncodeContext *ctx, unsigned int channel)
> +{
> +    FilterParams *fp[NUM_FILTERS] = { &ctx->cur_channel_params[channel].filter_params[FIR],
> +                                      &ctx->cur_channel_params[channel].filter_params[IIR], };
> +    int32_t **filter_state_buffer = (av_malloc((NUM_FILTERS)*sizeof(int32_t*));

doesnt build

CC      libavcodec/mlpenc.o
libavcodec/mlpenc.c: In function ‘mlp_encode_init’:
libavcodec/mlpenc.c:577:5: warning: ‘coded_frame’ is deprecated (declared at libavcodec/avcodec.h:2967) [-Wdeprecated-declarations]
libavcodec/mlpenc.c: In function ‘set_filter_params’:
libavcodec/mlpenc.c:1480:35: warning: passing argument 3 of ‘ff_lpc_calc_coefs’ makes integer from pointer without a cast [enabled by default]
libavcodec/lpc.h:93:5: note: expected ‘int’ but argument is of type ‘unsigned int *’
libavcodec/mlpenc.c: In function ‘apply_filter’:
libavcodec/mlpenc.c:1888:69: error: expected ‘)’ before ‘;’ token
libavcodec/mlpenc.c:2462:1: error: expected declaration or statement at end of input
libavcodec/mlpenc.c:1888:15: warning: unused variable ‘filter_state_buffer’ [-Wunused-variable]
libavcodec/mlpenc.c:1886:19: warning: unused variable ‘fp’ [-Wunused-variable]
libavcodec/mlpenc.c:2462:1: error: no return statement in function returning non-void [-Werror=return-type]
libavcodec/mlpenc.c: At top level:
libavcodec/mlpenc.c:205:19: warning: ‘restart_best_offset’ defined but not used [-Wunused-variable]
libavcodec/mlpenc.c:283:12: warning: ‘compare_decoding_params’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:377:13: warning: ‘copy_restart_frame_params’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:438:13: warning: ‘default_decoding_params’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:486:34: warning: ‘mlp_encode_init’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:702:21: warning: ‘bitcount_restart_header’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:746:21: warning: ‘bitcount_decoding_params’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:1242:21: warning: ‘write_access_unit’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:1338:13: warning: ‘input_data’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:1347:13: warning: ‘input_to_sample_buffer’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:1388:13: warning: ‘determine_quant_step_size’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:1496:13: warning: ‘determine_filters’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:1563:13: warning: ‘lossless_matrix_coeffs’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:1812:13: warning: ‘determine_bits’ defined but not used [-Wunused-function]

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160330/3c9ccf96/attachment.sig>