[FFmpeg-devel] [PATCH 02/10] swscale/arm/yuv2rgb: fix comments and factorize lsl in load_args_yuv422p

[Benoit Fouet]

Hi,

Le 25/03/2016 23:45, Matthieu Bouron a écrit :
> From: Matthieu Bouron<matthieu.bouron at stupeflix.com>
>
> ---
>   libswscale/arm/yuv2rgb_neon.S | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/libswscale/arm/yuv2rgb_neon.S b/libswscale/arm/yuv2rgb_neon.S
> index f40327b..aac0773 100644
> --- a/libswscale/arm/yuv2rgb_neon.S
> +++ b/libswscale/arm/yuv2rgb_neon.S
> @@ -172,11 +172,10 @@
>       vdup.16             d0, r10                                        @ d0  = y_coeff
>       vld1.16             {d1}, [r8]                                     @ d1  = *table
>       add                 r11, r2, r3                                    @ r11 = dst + linesize (dst2)
> -    lsl                 r8, r0, #2
> -    sub                 r3, r3, r8                                     @ r3 = linesize  * 2 - width * 4 (padding)
> -    sub                 r5, r5, r0                                     @ r5 = linesizeY * 2 - width     (paddingY)
> -    sub                 r7, r7, r0, lsr #1                             @ r7 = linesizeU     - width / 2 (paddingU)
> -    sub                 r12,r12,r0, lsr #1                             @ r12 = linesizeV    - width / 2 (paddingV)
> +    sub                 r3, r3, r0, lsl #2                             @ r3  = linesize  - width * 4 (padding)
> +    sub                 r5, r5, r0                                     @ r5  = linesizeY - width     (paddingY)
> +    sub                 r7, r7, r0, lsr #1                             @ r7  = linesizeU - width / 2 (paddingU)
> +    sub                 r12,r12,r0, lsr #1                             @ r12 = linesizeV - width / 2 (paddingV)
>       ldr                 r10,[sp, #120]                                 @ r10 = srcV
>   .endm
>   

nit: it would be cool to split: one for the comments and the other one 
for the lsl factorization.

-- 
Ben