[FFmpeg-devel] [PATCH] swscale cleanup

[Pedro Arthur]

May I push the patch?

2016-03-28 16:21 GMT-03:00 Pedro Arthur <bygrandao at gmail.com>:

> It was a little typo, attached patch fixed.
>
> 2016-03-28 16:09 GMT-03:00 Michael Niedermayer <michael at niedermayer.cc>:
>
>> On Mon, Mar 28, 2016 at 01:56:08PM -0300, Pedro Arthur wrote:
>> > Hi,
>> >
>> > This patch removes the previous swscale code which where under the
>> '#ifndef
>> > NEW_FILTER'.
>> > It also remove a few unused fields of SwsContext.
>> > Seems it doesn't introduce any regression (passes all FATE tests) but it
>> > would be better if someone could test it more.
>>
>> >  input.c                |    2
>> >  output.c               |   40 ++---
>> >  ppc/swscale_altivec.c  |    4
>> >  slice.c                |    4
>> >  swscale.c              |  336
>> +++----------------------------------------------
>> >  swscale_internal.h     |   10 -
>> >  utils.c                |   78 -----------
>> >  vscale.c               |    4
>> >  x86/swscale.c          |   38 +----
>> >  x86/swscale_template.c |   12 -
>> >  10 files changed, 65 insertions(+), 463 deletions(-)
>> > fbdf78f3edb890f485d5bcfc2b3edf55465db1f5  sws_cleanup.patch
>> > From d52cb0e25332a0327acdac89256beac4701f675a Mon Sep 17 00:00:00 2001
>> > From: Pedro Arthur <bygrandao at gmail.com>
>> > Date: Mon, 28 Mar 2016 13:25:18 -0300
>> > Subject: [PATCH] swscale: cleanup unused code
>> >
>> > Removed previous swscale code under '#ifndef NEW_FILTER'
>> > and removed unused fields of SwsContext
>>
>> fails to build on x86-32 here
>>
>> libswscale/x86/swscale.c: In function ‘ff_sws_init_swscale_x86’:
>> libswscale/x86/swscale.c:460:18: error: ‘SwsContext’ has no member named
>> ‘needApha’
>>
>> [...]
>>
>> --
>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> The worst form of inequality is to try to make unequal things equal.
>> -- Aristotle
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>>
>