[FFmpeg-devel] [PATCH 1/4] fate: wma: add lossless 24bits test

[Michael Niedermayer]

On Sun, May 01, 2016 at 06:47:32PM +0200, Christophe Gisquet wrote:
> 2016-05-01 15:54 GMT+02:00 Paul B Mahol <onemda at gmail.com>:
> > There where 2 distinct issues: 32bit instead of 16bit integers and
> > wrong handling of raw pcm.
> > The 96k is about the first one, last decoded frame md5 differs for example.
> 
> Added a test for the file with raw pcm tiles then.
> 
> -- 
> Christophe

>  fate/lossless-audio.mak         |    6 +++++-
>  ref/fate/lossless-wma24-1       |    1 +
>  ref/fate/lossless-wma24-2       |    1 +
>  ref/fate/lossless-wma24-rawtile |    1 +
>  4 files changed, 8 insertions(+), 1 deletion(-)
> fea68b4eb474317f8e089cb3e72acce909b2fe75  0001-fate-wma-add-lossless-24bits-tests.patch
> From 584999fcce24585f989d2dc770e8c7c85aa19db7 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Mon, 18 Apr 2016 12:53:21 +0200
> Subject: [PATCH 1/4] fate: wma: add lossless 24bits tests
> 
> Should evaluate coefficients and raw pcm tiles.
> ---
>  tests/fate/lossless-audio.mak         | 6 +++++-
>  tests/ref/fate/lossless-wma24-1       | 1 +
>  tests/ref/fate/lossless-wma24-2       | 1 +
>  tests/ref/fate/lossless-wma24-rawtile | 1 +
>  4 files changed, 8 insertions(+), 1 deletion(-)
>  create mode 100644 tests/ref/fate/lossless-wma24-1
>  create mode 100644 tests/ref/fate/lossless-wma24-2
>  create mode 100644 tests/ref/fate/lossless-wma24-rawtile
> 
> diff --git a/tests/fate/lossless-audio.mak b/tests/fate/lossless-audio.mak
> index 58641ab..d292853 100644
> --- a/tests/fate/lossless-audio.mak
> +++ b/tests/fate/lossless-audio.mak
> @@ -25,8 +25,12 @@ fate-lossless-tta: CMD = crc -i $(TARGET_SAMPLES)/lossless-audio/inside.tta
>  FATE_SAMPLES_LOSSLESS_AUDIO-$(call DEMDEC, TTA, TTA) += fate-lossless-tta-encrypted
>  fate-lossless-tta-encrypted: CMD = crc -password ffmpeg -i $(TARGET_SAMPLES)/lossless-audio/encrypted.tta
>  
> -FATE_SAMPLES_LOSSLESS_AUDIO-$(call DEMDEC, ASF, WMALOSSLESS) += fate-lossless-wma
> +FATE_SAMPLES_LOSSLESS_AUDIO-$(call DEMDEC, ASF, WMALOSSLESS) += fate-lossless-wma fate-lossless-wma24-1 fate-lossless-wma24-2 fate-lossless-wma24-rawtile
>  fate-lossless-wma: CMD = md5 -i $(TARGET_SAMPLES)/lossless-audio/luckynight-partial.wma -f s16le -frames 209
> +fate-lossless-wma24-1: CMD = md5 -i $(TARGET_SAMPLES)/lossless-audio/master_audio_2.0_24bit.wma -f s24le
> +fate-lossless-wma24-2: CMD = md5 -i $(TARGET_SAMPLES)/lossless-audio/Mega_Weird_Audio_Test_24bit.wma -f s24le

> +fate-lossless-wma24-rawtile: CMD = md5 -i $(TARGET_SAMPLES)/lossless-audio/g2_24bit.wma -f s24le

where can i find that file ?
i assume i should upload it ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160502/4cff55a5/attachment.sig>