[FFmpeg-devel] [PATCH] fate: add aecho test

[Michael Niedermayer]

On Sat, May 14, 2016 at 09:07:17AM +0000, Petru Rares Sincraian wrote:
> 
> 
> Hi there,
> 
> Here I add a new test for aecho filter.

>  fate/filter-audio.mak |    5 
>  ref/fate/filter-aecho |  286 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 291 insertions(+)
> efd0670e8f0c0c23e9d1392052b03ac4b7e047f0  0001-fate-add-aecho-test.patch
> From 25e8de6f4caa08a1903a6756ca718ef06722d116 Mon Sep 17 00:00:00 2001
> From: Petru Rares Sincraian <psincraian at outlook.com>
> Date: Sat, 14 May 2016 11:04:25 +0200
> Subject: [PATCH] fate: add aecho test

this fails on x86-32

--- ffmpeg/tests/ref/fate/filter-aecho 2016-05-14 13:33:43.477820778 +0200
+++ tests/data/fate/filter-aecho        2016-05-14 15:16:00.441950067 +0200
@@ -46,241 +46,241 @@
 0,      40960,      40960,     1024,     4096, 0x7c4ce7e9
 0,      41984,      41984,     1024,     4096, 0x5eddeb19
 0,      43008,      43008,     1024,     4096, 0x351c08c4
-0,      44032,      44032,     1024,     4096, 0x30c6db8f
-0,      45056,      45056,     1024,     4096, 0x1c4b3258
-0,      46080,      46080,     1024,     4096, 0xe32d157e
+0,      44032,      44032,     1024,     4096, 0x4dd4db91
+0,      45056,      45056,     1024,     4096, 0x07ad3256
+0,      46080,      46080,     1024,     4096, 0xe6131580
 0,      47104,      47104,     1024,     4096, 0xbbe9e635
-0,      48128,      48128,     1024,     4096, 0x7e8214dc
-0,      49152,      49152,     1024,     4096, 0xd671e4c1
-0,      50176,      50176,     1024,     4096, 0xd268f457
-0,      51200,      51200,     1024,     4096, 0x6051018e
+0,      48128,      48128,     1024,     4096, 0x8f4014de
+0,      49152,      49152,     1024,     4096, 0xbc53e4bf
+0,      50176,      50176,     1024,     4096, 0xf2b6f459
+0,      51200,      51200,     1024,     4096, 0x83350192


you can test that with somethng like
./configure  --arch=x86_32 --target-os=linux --extra-cflags=-m32 --extra-ldflags=-m32  --enable-cross-compile

aecho uses floats so rounding and precission differences can cause
differences between platforms
you could improve aecho so it does not depend on floats for filtering
of s16 samples
but maybe you can find parameters that give the same result on all
platforms without that
or a small reference file would need to be added and tiny_psnr used
for comparing

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160514/e07f19c6/attachment.sig>