[FFmpeg-devel] AVClass & AVOption [VOTE]

[James Almer]

On 5/29/2016 6:30 PM, Ronald S. Bultje wrote:
> Hi,
> 
> On May 29, 2016 4:59 PM, "James Almer" <jamrial at gmail.com> wrote:
>>
>> On 5/29/2016 5:45 PM, Ronald S. Bultje wrote:
>>> Hi,
>>>
>>> On Sun, May 29, 2016 at 3:13 PM, Marton Balint <cus at passwd.hu> wrote:
>>>
>>>>
>>>>
>>>> On Sun, 29 May 2016, Michael Niedermayer wrote:
>>>>
>>>> Hi
>>>>>
>>>>> It was suggested in the IRC meeting today that i start a vote to
>>>>> resolve if AVClass & AVOption should be added to AVCodecParameters
>>>>> This question needs to be awnsered before the next release because
>>>>> the ABI would be broken if its added afterwards
>>>>> the lack of any decission blocks the release which is worse than
>>>>> either decission, otherwise a vote might be silly for such technical
>>>>> question but eve a bad decission is better than no decission here
>>>>>
>>>>>
>>>>> The disadvanatges are:
>>>>> 1 more field in the struct
>>>>> a high level API that some feel is unneeded for AVCodecParameters
>>>>> it could be confusing to some that there are 2 different ways to
>>>>> access the fields
>>>>> people might use it as av_log() context when they intended to use a
>>>>> different context for it
>>>>> There are probably more please help fill the list if you know more
>>>>>
>>>>> The advanatges are:
>>>>> More consistent availability of AVOptions and AVClass in public
>>>>> structs
>>>>> Makes supporting multiple FFmpeg versions and distros easier and
>>>>> cleaner for applications. (reduces lists of #if version checks)
>>>>> Provides default/min/max values, allows basic validity checking within
>>>>> min/max
>>>>> Avoids mysterious crashes if an application uses avoption functions
>>>>> on AVCodecParameters
>>>>> Introspection
>>>>> Serialization support that may be usefull for ffserver or an
> application
>>>>> replacing ffserver
>>>>>
>>>>>
>>>>> An application that doesnt want to use AVOptions or AVClass can
>>>>> completey ignore them.
>>>>>
>>>>> Please state clearly if you agree to add AVClass&AVOption to
>>>>> AVCodecParameters or if you disagree about adding it or if you dont
>>>>> care either way
>>>>>
>>>>> The vote will end 1 week from now, simple 50% majority (Yes vs no)
>>>>> I dont really know who should be eligible for voting, so i suggest
>>>>> everyone from the vote comittee but iam happy with anything, just
>>>>> stating somethng ...
>>>>>
>>>>
>>>> I am in favor of adding AVClass.
>>>
>>>
>>> You're not in the list [1]?
>>>
>>> Ronald
>>>
>>> [1] https://ffmpeg.org/pipermail/ffmpeg-devel/2015-October/182207.html
>>
>> At least one the person in the list has apparently left the project, so
> maybe
>> we could suggest adding recurrent contributors like Marton and Thilo.
> 
> Probably, yes. Is it just Thilo or are others missing also? What were the
> criteria again?
> 
> Ronald

The original criteria was i think 50 commits in the past year or so. This
was back in mid 2015. After that a couple people were added based on
suggestions since many long time contributors and maintainers didn't meet
that criteria.