[FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

[Nicolas George]

Le quartidi 24 brumaire, an CCXXV, Hendrik Leppkes a écrit :
> I disagree with that, this is generic utility code, not a tight
> algorithm loop, where absolute efficiency is not necessarily required,
> and disregarding code simplicity amd consistency will just harm in the
> long-run.

We can discuss that. Remember that they are fields in a structure, not
code: if these fields are accessed in a tight loop, your argument
vanishes.

I agree that most of these fields will likely not be used in very tight
loops. But "most", "likely", "very", because of these caveats, the
concern can not be dismissed entirely.

And remember that the indirection also harms the code simplicity,
greatly.

I claim that my solution yields overall simpler code. And more
efficient.

(I could play and say that if you do not see how the indirection harms
the simplicity of the code, your advice is worthless on the matter, but
that would be vile. If you do not see, ask and I will explain; just not
right now because I need to wake up early tomorrow.)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161114/2ea8e45c/attachment.sig>