[FFmpeg-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Wed Nov 16 20:46:59 EET 2016


On 16.11.2016 15:14, Michael Niedermayer wrote:
> On Wed, Nov 16, 2016 at 01:48:05PM +0100, wm4 wrote:
>> On Wed, 16 Nov 2016 13:21:34 +0100
>> Michael Niedermayer <michael at niedermayer.cc> wrote:
>>> On Tue, Nov 15, 2016 at 09:56:16PM +0100, Andreas Cadhalpun wrote:
>>>> However, considering the sheer amount of crashes in libschroedinger and
>>>> that it's apparently not maintained anymore, it might be better to
>>>> simply remove this decoder.  
>>>
>>> id say decoders which crash should be marked as
>>> AV_CODEC_CAP_EXPERIMENTAL
>>
>> Experimental implies it's early work in progress which will stabilize
>> later.
>>
>> libschroedinger is completely dead, and it's entirely possible that
>> you're the person who cares most about it on this planet.
>>
> 
>> Should we introduce a AV_CODEC_CAP_TRASH flag?
> 
> i dont know, but i am not against a flag marking decoders with
> security issues or unmaintained code.
> i think we should use a different term than "trash", we should not
> call other peoples code anything offensive or insulting.

Maybe AV_CODEC_CAP_DEPRECATED?

But I'm not sure if adding this for just one decoder makes much sense.

Best regards,
Andreas


More information about the ffmpeg-devel mailing list