[FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

[Carl Eugen Hoyos]

2016-11-21 12:30 GMT+01:00 wm4 <nfxjfg at googlemail.com>:
> On Sun, 20 Nov 2016 14:24:00 +0100
> Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
>> 2016-11-20 13:52 GMT+01:00 Clément Bœsch <u at pkh.me>:
>>
>> >> > +static const AVOption sbuffer_options[] = {
>> >> > +    { "time_base",      NULL, OFFSET(time_base),  AV_OPT_TYPE_RATIONAL, { .dbl = 0 }, 0, INT_MAX, S },
>> >> > +    { "format",         NULL, OFFSET(sub_format), AV_OPT_TYPE_INT,      { .i64 = -1 }, -1, 1, S, "format" },
>> >> > +        { "unspecified", NULL, 0, AV_OPT_TYPE_CONST, {.i64=-1}, INT_MIN, INT_MAX, S, "format" },
>> >> > +        { "bitmap",      NULL, 0, AV_OPT_TYPE_CONST, {.i64=0},  INT_MIN, INT_MAX, S, "format" },
>> >> > +        { "text",        NULL, 0, AV_OPT_TYPE_CONST, {.i64=1},  INT_MIN, INT_MAX, S, "format" },
>> >>
>> >> Implies no mixed subs. I'm fine with that, but might be restrictive.
>> >>
>> >
>> > Yeah, so far we don't have such things AFAIK. But we could replace this
>> > with a mask later on. It was simpler for the initial format negotiation
>> > that way.
>>
>> Will this work with our current external teletext decoder?
>> (Will it work with a hypothetical future teletext decoder that provides both
>> bitmap and text when decoding?)
>
> That's a different case. I was talking about subtitles with need both
> text and images for correct display. Different output formats can be
> handled with get_format or a private option or so.

So it does already work with our current external teletext decoder and
a hypothetical future teletext decoder that provides both bitmap and
text when decoding?

Thank you, Carl Eugen