[FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

[James Almer]

On 11/26/2016 6:00 PM, Rostislav Pehlivanov wrote:
> On 26 October 2016 at 23:43, Rostislav Pehlivanov <atomnuker at gmail.com>
> wrote:
> 
>>
>>
>> On 26 October 2016 at 23:33, Andreas Cadhalpun <
>> andreas.cadhalpun at googlemail.com> wrote:
>>
>>> On 27.10.2016 00:16, Rostislav Pehlivanov wrote:
>>>> On 26 October 2016 at 22:48, James Almer <jamrial at gmail.com> wrote:
>>>>
>>>>> On 10/26/2016 6:19 PM, Rostislav Pehlivanov wrote:
>>>>>> Also removes url_feof from libavformat.v which should have been
>>>>>> removed long ago and changed the multipart jpeg boundary tag to
>>>>>> ffmpeg rather than ffserver (it's arbitrary).
>>>>>
>>>>> [...]
>>>>>
>>>>>> diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v
>>>>>> index c961cd8..47d5ddc 100644
>>>>>> --- a/libavformat/libavformat.v
>>>>>> +++ b/libavformat/libavformat.v
>>>>>> @@ -1,19 +1,6 @@
>>>>>>  LIBAVFORMAT_MAJOR {
>>>>>>      global:
>>>>>>          av*;
>>>>>> -        #FIXME those are for ffserver
>>>>>> -        ff_inet_aton;
>>>>>> -        ff_socket_nonblock;
>>>>>> -        ff_rtsp_parse_line;
>>>>>> -        ff_rtp_get_local_rtp_port;
>>>>>> -        ff_rtp_get_local_rtcp_port;
>>>>>> -        ffio_open_dyn_packet_buf;
>>>>>> -        ffio_set_buf_size;
>>>>>> -        ffurl_close;
>>>>>> -        ffurl_open;
>>>>>> -        ffurl_write;
>>>>>> -        #those are deprecated, remove on next bump
>>>>>> -        url_feof;
>>>>>>      local:
>>>>>>          *;
>>>>>>  };
>>>>>
>>>>> No, this can't be done until the next major bump. url_feof is even
>>> guarded
>>>>> by an scheduled FF_API define.
>>>>>
>>>>> The rest should be ok, but anything that implies a library ABI break
>>> can't
>>>>> be done just yet. Wait for other comments and/or testing. This removes
>>> a
>>>>> lot of things after all.
>>>>>
>>>> Fixed version attached without removing url_feof (apparently that's
>>> meant
>>>> to go in the next bump, wasn't forgotten)
>>>
>>> No, none of the symbols can be removed without a major bump. The simple
>>> reason
>>> is that a ffserver built from the 3.1 branch still has to work with the
>>> libavformat from the 3.2 branch.
>>>
>>> Best regards,
>>> Andreas
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>
>> Thanks for telling me,
>> Attached patch will only remove the ffserver program and documentation
>> relating to it.
>> The ffm demuxer/muxer will be removed with the next bump like url_feof.
>>
> 
> 
> Since a month has passed, reynaldo still hasn't responded, I think it's
> long overdue to push this patch. I've attached a new version of the patch
> which only removes the ffserver program (without touching anything else),
> which had been OK'd by James Almer.
> 
> I'll push this on Tuesday next week, the 29th of November.

Since at least Michael is still working towards getting it working as a
standalone program it is acceptable to wait until 3.3 is close to being
branched from master.

It *must not* make it into that release, but until then being in the tree
or out of it will not hurt, and will make Michael's and Reynaldo's efforts
easier.