[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

[Vittorio Giovara]

On Wed, Nov 30, 2016 at 1:21 PM, Nicolas George <george at nsup.org> wrote:
> Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit :
>> Signed-off-by: Vittorio Giovara <vittorio.giovara at gmail.com>
>> ---
>
>> Please CC.
>
> You can achieve the same result more reliably by setting the reply-to
> header.

Oh, nice trick, I'll try it out next time.

>> Vittorio
>>
>>  libavutil/pixdesc.c | 1 +
>>  libavutil/pixfmt.h  | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c
>> index 3b9c45d..04eab0b 100644
>> --- a/libavutil/pixdesc.c
>> +++ b/libavutil/pixdesc.c
>> @@ -2183,6 +2183,7 @@ static const char *color_primaries_names[AVCOL_PRI_NB] = {
>>      [AVCOL_PRI_SMPTE428] = "smpte428",
>>      [AVCOL_PRI_SMPTE431] = "smpte431",
>>      [AVCOL_PRI_SMPTE432] = "smpte432",
>> +    [AVCOL_PRI_JEDEC_P22] = "jedec-p22",
>>  };
>>
>>  static const char *color_transfer_names[] = {
>> diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
>> index dfb1b11..d6c5a57 100644
>> --- a/libavutil/pixfmt.h
>> +++ b/libavutil/pixfmt.h
>> @@ -413,6 +413,7 @@ enum AVColorPrimaries {
>>      AVCOL_PRI_SMPTEST428_1 = AVCOL_PRI_SMPTE428,
>>      AVCOL_PRI_SMPTE431    = 11, ///< SMPTE ST 431-2 (2011)
>>      AVCOL_PRI_SMPTE432    = 12, ///< SMPTE ST 432-1 D65 (2010)
>> +    AVCOL_PRI_JEDEC_P22   = 22, ///< JEDEC P22 phosphors
>>      AVCOL_PRI_NB                ///< Not part of ABI
>>  };
>
> Are you leaving a gap on purpose? There was no gap until now.

This is the value specified in the 23001-8_2013 document.

> (Also, why are the values specified? And despite being "not part of the
> ABI", AVCOL_PRI_NB is used outside lavu.)

Hm those should probably be addressed too, the decoder and filters
ones are simple, while static options might be tricky.
-- 
Vittorio