[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

[James Almer]

On 11/30/2016 5:16 PM, Nicolas George wrote:
> Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit :
>> I am sorry, I don't have any public link I can share.
> 
> Ok. Thanks for James for his gratis-but-sell-your-soul link.
> 
>>> But I am pretty sure this document does not specify the values of enums
>>> in FFmpeg's API. If the rest of the code requires that the values of the
>>> enum match values in files or protocol, then I think a comment must say
>>> so clearly. And if not, then the gap is not needed.
>> It does.
> 
> Who does what? Your answer is ambiguous.

It is needed like this. Decoders and encoders (h264, hevc, vc1, mpeg2, prores,
libx264, libx265, nvenc, etc), demuxers and muxers (mov, matroka), all expect
the enum values to follow those described by this spec.

> 
> And can you explain where it does? I looked at the code and did not see
> it.
> 
> What happens if we need to support a system of primaries that does not
> come from the same organization?

Custom mapping functions would be written for such unusual cases, i guess.

> 
> Regards,
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>