[FFmpeg-devel] [PATCH 1/3] avformat/matroska: write FlagInterlaced element in WebM

[James Almer]

On 10/3/2016 1:21 PM, James Almer wrote:
> On 10/3/2016 12:27 PM, Dave Rice wrote:
>> Hi,
>>
>>> On Oct 2, 2016, at 7:14 PM, James Almer <jamrial at gmail.com> wrote:
>>>
>>> On 9/27/2016 3:03 PM, James Almer wrote:
>>>> It's listed as supported in both https://www.webmproject.org/docs/container/
>>>> and https://matroska.org/technical/specs/index.html
>>>>
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>> ---
>>>> libavformat/matroskaenc.c | 41 +++++++++++++++++++++--------------------
>>>> 1 file changed, 21 insertions(+), 20 deletions(-)
>>>
>>> Ping.
>>
>> Untested but from a read through, the patch looks good. FlagInterlaced is supported in both Matroska and webM, whereas FieldOrder (a new field from the CELLAR work on Matroska) is only supported in Matroska. IMHO though I think that FlagInterlaced without information on FieldOrder is not so useful and that the webM project should consider adopting FieldOrder as well. I'd prefer to see a patch to webM to consider adding FieldOrder to the format rather than see FieldOrder removed from the webM muxer in FFmpeg.
> 
> FieldOrder is not being removed from the WebM muxer with this patch. It,
> alongside FlagInterlaced, was never written by it. Only by the Matroska
> muxer.
> This patch follows the current spec and adds FlagInterlaced to WebM by
> moving the mode check to only filter out FieldOrder instead of the two
> elements when targeting WebM.
> 
> If Google ever changes the spec to also support FieldOrder then adding
> it will be as simple as removing the mode check.
> 

Pushed, thanks.