[FFmpeg-devel] [PATCH]lavu/hwaccel_vaapi: Add a fixme for the missing byte_order check
Carl Eugen Hoyos
cehoyos at ag.or.at
Wed Oct 5 15:06:46 EEST 2016
Hi!
I cannot test here but afaict, the current implementation of
vaapi_pix_fmt_from_fourcc() can't be correct.
Please comment, Carl Eugen
-------------- next part --------------
From 52b0af32b965c2fce23afe8b57289e497f17f011 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <cehoyos at ag.or.at>
Date: Wed, 5 Oct 2016 14:04:25 +0200
Subject: [PATCH] lavu/hwcontext_vaapi: Add a fixme for the missing byte_order
check.
---
libavutil/hwcontext_vaapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index 92fa235..3319839 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -92,6 +92,7 @@ typedef struct VAAPISurfaceMap {
}
// The map fourcc <-> pix_fmt isn't bijective because of the annoying U/V
// plane swap cases. The frame handling below tries to hide these.
+// FIXME: Take VAImageFormat->byte_order into account
static struct {
unsigned int fourcc;
unsigned int rt_format;
--
1.7.10.4
More information about the ffmpeg-devel
mailing list