[FFmpeg-devel] [PATCH] libavformat/utils: hls live duration form bit rate is not accurate

[Michael Niedermayer]

On Mon, Oct 10, 2016 at 09:13:02AM +0200, Hendrik Leppkes wrote:
> On Mon, Oct 10, 2016 at 9:05 AM, zzj <zzjjob at gmail.com> wrote:
> > Signed-off-by: zzj <zzjjob at gmail.com>
> > ---
> >  libavformat/utils.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index 5be1e86..c7d6a41 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -2776,7 +2776,7 @@ static void estimate_timings(AVFormatContext *ic, int64_t old_offset)
> >           * the components */
> >          fill_all_stream_timings(ic);
> >          ic->duration_estimation_method = AVFMT_DURATION_FROM_STREAM;
> > -    } else {
> > +    } else if (strcmp(ic->iformat->name, "hls,applehttp")) {
> >          /* less precise: use bitrate info */
> >          estimate_timings_from_bit_rate(ic);
> >          ic->duration_estimation_method = AVFMT_DURATION_FROM_BITRATE;
> 

> format name comparisons in generic code should really be avoided, if
> at all possible.

not arguing in favor of the specific patch but name comparisons are
how the iformat is compared currently.
A discussion to change this in a seperate thread here on ffmpeg-devel
would be a good idea i think but
This isnt a problem of this specific patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161010/e7481b6b/attachment.sig>