[FFmpeg-devel] [PATCH] avformat/matroska: fix MatroskaVideoFieldOrder enum values

Michael Niedermayer michael at niedermayer.cc
Thu Oct 13 01:34:59 EEST 2016


On Wed, Oct 12, 2016 at 04:54:56PM -0300, James Almer wrote:
> The spec says
> 
> 9: Interlaced with bottom field displayed first and top field stored first
> 14: Interlaced with top field displayed first and bottom field stored first
> 
> And avcodec.h states
> 
> AV_FIELD_TB,          //< Top coded first, bottom displayed first
> AV_FIELD_BT,          //< Bottom coded first, top displayed first
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavformat/matroska.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/matroska.h b/libavformat/matroska.h
> index 1ff76e6..15e401c 100644
> --- a/libavformat/matroska.h
> +++ b/libavformat/matroska.h
> @@ -286,8 +286,8 @@ typedef enum {
>      MATROSKA_VIDEO_FIELDORDER_UNDETERMINED = 2,
>      MATROSKA_VIDEO_FIELDORDER_TT           = 1,
>      MATROSKA_VIDEO_FIELDORDER_BB           = 6,
> -    MATROSKA_VIDEO_FIELDORDER_BT           = 9,
> -    MATROSKA_VIDEO_FIELDORDER_TB           = 14,
> +    MATROSKA_VIDEO_FIELDORDER_TB           = 9,
> +    MATROSKA_VIDEO_FIELDORDER_BT           = 14,
>  } MatroskaVideoFieldOrder;

this requires a bump in the version to cause a change to
LIBAVFORMAT_IDENT

the demuxer should use this version to detect and correct the past
muxer mistake

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161013/bfc97c93/attachment.sig>


More information about the ffmpeg-devel mailing list