[FFmpeg-devel] [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the edges

[Michael Bradshaw]

On Thu, Oct 13, 2016 at 6:49 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:
>
> >  libopenjpegenc.c |   18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> > 17061aee3e88729993c9581f688cbfda01fccaac  0001-libopenjpegenc-fix-out-
> of-bounds-reads-when-filling-.patch
> > From 1461064c1eaabb71661f9ff68b94f35a1b98e3b5 Mon Sep 17 00:00:00 2001
> > From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> > Date: Thu, 13 Oct 2016 22:14:46 +0200
> > Subject: [PATCH] libopenjpegenc: fix out-of-bounds reads when filling the
> >  edges
> >
> > The calculation of width/height should round up, not round down to
> > prevent setting width or height to 0.
> >
> > Also image->comps[compno].w is unsigned (at least in openjpeg2), so the
> > calculation could silently wrap around without the explicit cast to int.
>
> LGTM, iam not libopenjpegenc maintainer though


Looks good to me too. Please feel free to apply it. Thanks!