[FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

[Michael Niedermayer]

On Tue, Oct 18, 2016 at 12:46:56PM -0400, Greg Rowe wrote:
> >see
> >libavfilter/asrc_sine.c
> >this code should probably be reused / factored
> >(note, any code moving/factoring of existing code should be in a
> > seperate patch)
> 
> Since silenceremove works only on AV_SAMPLE_FMT_DBL is it OK to use
> floating point for the generated tone or is it recommended to create
> the tone and then convert it to double samples or some other
> approach?

can you write a fate test for the filter which is portable accross
platforms ?

every filter should ideally have a fate test.
If you can write a working an portable fate test with float sine
then i have no objections to it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161018/9ca7f2c0/attachment.sig>