[FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

[Michael Niedermayer]

On Tue, Oct 18, 2016 at 11:15:50PM -0300, James Almer wrote:
> On 10/17/2016 9:57 PM, Michael Niedermayer wrote:
> > On Sun, Oct 16, 2016 at 09:34:50PM -0300, James Almer wrote:
> >> Fixes valgrind warning about "Conditional jump or move depends on uninitialised value(s)"
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>  libavformat/mov.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > This should be suppressable by adding it to
> > tests/fate-valgrind.supp
> 
> I'll leave that to someone else. No idea how to add stuff to that file.

IIRC, valgrind can print the proper formatted supperssion, so
should only require copy and paste from that


> 
> Should i drop this patch? Zero initializing a buffer in stack wouldn't
> hurt IMO.

iam not objecting to the zero init

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161019/4c849b03/attachment.sig>